search

hermit-os / hermit-entry

Hermit's loading and entry API.
https://crates.io/crates/hermit-entry
Apache License 2.0
5 stars 4 forks source link

Added command line and environment to the hermit entry parameters #38

Open jounathaen opened 2 weeks ago

jounathaen commented 2 weeks ago

I'd like to get rid of the hypercalls in uhyve just to retrieve the env and argv. I think it makes sense to add them to the boot information, as they are available at boot time anyway.

(Once implemented in uhyve and hermit, this would solve https://github.com/hermit-os/uhyve/issues/35)

jounathaen commented 2 weeks ago

I think that is a good approach, but it should be considered that we potentially pass hundreds of environment variables.

As changing uhyve to use device trees is a bigger project, maybe we can still go with this approach as an intermediate step? (To at get rid of the hypercall first)

mkroening commented 2 weeks ago

I'd like to avoid having to do a entry version jump for this.

I think gradual migration should be easy. I'll open a draft PR tomorrow for initial device tree support for Uhyve, just for bootargs.