search

hermit-os / kernel

A Rust-based, lightweight unikernel.
http://hermit-os.org
Apache License 2.0
1.16k stars 85 forks source link

Skip APIC detection on Uhyve #1352

Open jounathaen opened 1 month ago

jounathaen commented 1 month ago

I'm not 100% sure about this one, but AFAIK, Uhyve does not provide an APIC or IO-APIC. But if the acpi feature is active, the kernel unsuccessfully probes the memory to find one. I think, we can skip the search for an APIC if we are on Uhyve and save a few CPU cycles.

stlankes commented 1 month ago

I would assume that we need at least a local APIC to program the timer interrupt.

jounathaen commented 1 month ago

Yes. Something like this is happening. But the probing can probably be skipped.