search

hermit-os / uhyve

A specialized hypervisor for Hermit.
Apache License 2.0
251 stars 29 forks source link

fix(x86_64): don't panic on unknown port #691

Closed mkroening closed 1 month ago

mkroening commented 1 month ago

QEMU and Firecracker don't panic here either.

With this, hermit::arch::x86_64::shutdown from https://github.com/hermit-os/kernel/pull/1181 would also work on Uhyve, though proper exits via system calls still go through the exit hypercall.

jounathaen commented 1 month ago

LGTM!

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 68.05%. Comparing base (3e6edc2) to head (de6956d).

Files Patch % Lines
src/linux/x86_64/kvm_cpu.rs 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #691 +/- ## ========================================== - Coverage 68.11% 68.05% -0.06% ========================================== Files 20 20 Lines 2308 2310 +2 ========================================== Hits 1572 1572 - Misses 736 738 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.