search

hernad / atom-language-harbour

atom editor language harbour
MIT License
3 stars 7 forks source link

Make the grammar PCRE compatible #9

Closed pchaigno closed 7 years ago

pchaigno commented 7 years ago

This pull request changes 1 regular expressions in an attempt to make the grammar PCRE-compatible. While Atom uses an Oniguruma engine, github.com (which rely on this grammar for Harbour highlighting) uses a PCRE-based engine. The two engines interpret \h differently, and only Oniguruma engines support implicit count modifiers ({,n}).

pchaigno commented 7 years ago

@hernad Did you get a chance to look into this?

hernad commented 7 years ago

@pchaigno, I didn't. Your precise elaboration says that you know the subject better than me, so I will merge without looking into :) Version 3.6.0

Thank you for your submission.