hero-org / herocast

herocast is Farcaster’s leading open-source client. Our goal is to decentralize power on the internet, faster.
https://app.herocast.xyz
GNU Affero General Public License v3.0
64 stars 30 forks source link

The application is taking up the entire screen width, no matter how large it is #452

Closed AjayiMike closed 1 month ago

AjayiMike commented 1 month ago

Describe the bug This issue is more like an improvement request than a bug.

Currently, the application is taking up the entire screen width, no matter how large it is. And this makes it to look very bad on very large screens. I work with a 34" screen, and herocast interface does not look it best on it. See below 👇

Screenshot 2024-08-07 at 15 35 37

I went further to simulate a much larger screen (9K) and this is how it looked Screenshot 2024-08-07 at 15 37 15

To Reproduce Steps to reproduce the behavior:

  1. open https://app.herocast.xyz/feeds or run it locally and open it on large screen
  2. You'll see that the application content is taking up the entire screen thereby making it look very bad

Expected behavior The Application should have a maximum width (depending on the screen size) that is center aligned. This will make the application look very good no matter the size of the screen it is being view on

It should look good on large screen like the site below 👇

Screenshot 2024-08-07 at 16 23 56

Screenshots Included above

Browser / OS / Deivce (help us fix this faster): Chrome and Arc on MacOS

Additional context To fix this, we can use tailwind container with predefined max-width for different screen sizes to achieve this Screenshot 2024-08-07 at 16 34 10

hellno commented 1 month ago

thanks for this awesome issue and description. would be happy if you can provide a fix that keeps the whole app more center and just extends the background evenly while maintaining max width

AjayiMike commented 1 month ago

Sure, Will get to it ASAP