search

hero-saver / threejs

GNU General Public License v3.0
14 stars 9 forks source link

Certain geometries don't get included in the generated model. #7

Open CodilX opened 3 years ago

CodilX commented 3 years ago

I'm sure there have to be more, not just these two. There doesn't seem to be any errors during generation, and adding console.log(group) after all meshes have been processed shows them in the group.

scc

jecourtney commented 3 years ago

CodiX, How are you even getting that far? Models are currently scrambled.

CodilX commented 3 years ago

CodiX, How are you even getting that far? Models are currently scrambled.

You can use the waybackmachine to get previous versions of HeroForge javascript libraries and force the browser to use those. There are instructions on the herosaver subreddit.

jecourtney commented 3 years ago

CodiX, How are you even getting that far? Models are currently scrambled.

You can use the waybackmachine to get previous versions of HeroForge javascript libraries and force the browser to use those. There are instructions on the herosaver subreddit.

https://www.reddit.com/r/Herosaver/ posts are gone, at least I see nothing about wayback in there. Can you explain the process?

CodilX commented 3 years ago

CodiX, How are you even getting that far? Models are currently scrambled.

You can use the waybackmachine to get previous versions of HeroForge javascript libraries and force the browser to use those. There are instructions on the herosaver subreddit.

https://www.reddit.com/r/Herosaver/ posts are gone, at least I see nothing about wayback in there. Can you explain the process?

There is a link in one of the posts. Also there is an another issue opened up for garbled meshes, ask there.

What I noticed was that during the geometry generation, items like horns or the base result in 1 vertex which is probably why they're not showing up in the generated model?

Inserting console.log(mesh.name, vertices.count) right before if (vertices !== undefined) { results in this:

hornSideL 482
hornSideR 482
<...>
faceUpper 426
eyebrows 386
base 1120
baseRim 1634

But adding console.log(mesh.name, newGeometry.vertices.length) right before return newGeometry shows the vertices have been lost

hornSideL 1 
hornSideR 1 
<...>
faceUpper 318 
eyebrows 292 
base 1 
baseRim 1346

Does anyone have any ideas why the base and horns don't properly generate?