herobank110 / factorygame

Python game engine to have a 2d movable "graph".
https://factorygame.readthedocs.io
MIT License
1 stars 2 forks source link

The codebase could use a PEP8 cleanup #10

Open szabopeter opened 3 years ago

szabopeter commented 3 years ago

Summary of a flake8 --statistics --count --max-line-length=120 . command shows the following

4       E101 indentation contains mixed spaces and tabs
3       E115 expected an indented block (comment)
5       E116 unexpected indentation (comment)
8       E122 continuation line missing indentation or outdented
10      E124 closing bracket does not match visual indentation
3       E125 continuation line with same indent as next logical line
99      E128 continuation line under-indented for visual indent
2       E131 continuation line unaligned for hanging indent
2       E202 whitespace before ')'
25      E221 multiple spaces before operator
3       E225 missing whitespace around operator
6       E228 missing whitespace around modulo operator
11      E231 missing whitespace after ','
1       E251 unexpected spaces around keyword / parameter equals
6       E261 at least two spaces before inline comment
8       E265 block comment should start with '# '
77      E266 too many leading '#' for block comment
26      E301 expected 1 blank line, found 0
49      E302 expected 2 blank lines, found 1
18      E303 too many blank lines (2)
2       E401 multiple imports on one line
1       E402 module level import not at top of file
13      E701 multiple statements on one line (colon)
21      F401 'GameplayStatics' imported but unused
2       F821 undefined name 'TEMPLATE_FILENAME_PREFIX'
2       W191 indentation contains tabs
14      W291 trailing whitespace
2       W292 no newline at end of file
17      W293 blank line contains whitespace
2       W391 blank line at end of file
10      W503 line break before binary operator
452
szabopeter commented 3 years ago

@herobank110 Should I go ahead and fix these or do you insist on non-PEP8 formatting?

herobank110 commented 3 years ago

Good call, the codebase would definitely benefit from a pep8 cleanup

The rational for double hash ## comments is doxygen picks them up for documenting variables. Unless you think there is a better way of doing this.