search

herobrine99dan / NESS-Reloaded

NESS Reloaded is an anticheat that aims to support lots of minecraft versions (from 1.8 to 1.17.1) without losing the advantage of having powerful checks
GNU General Public License v3.0
47 stars 5 forks source link

General code cleanup #77

Open A248 opened 3 years ago

A248 commented 3 years ago
herobrine99dan commented 3 years ago

Remove remaining reliance on NESSAnticheat.getInstance() = Done

herobrine99dan commented 3 years ago

Remove remaining reliance on NESSAnticheat.getInstance() = Done? Avoid public fields in MovementValues = Done?

A248 commented 3 years ago

https://github.com/herobrine99dan/NESS-Reloaded/commit/079074c02efff1a36eff200bc5a97ff9e6ebba17 https://github.com/herobrine99dan/NESS-Reloaded/commit/1d62a88ffe4ea84c8e77cf5f035a0a745e89c0b3 https://github.com/herobrine99dan/NESS-Reloaded/commit/dbfb674f4550c81ed7ae4c1dd351091588cd3a31 https://github.com/herobrine99dan/NESS-Reloaded/commit/d4765ef1b5e0c46138ca16544d5c584622b20838 https://github.com/herobrine99dan/NESS-Reloaded/commit/2855bdc07507e43a1cac9ef9882bb743ace2b145

herobrine99dan commented 3 years ago

Remove static methods from Utility class

herobrine99dan commented 3 years ago
  • ~Remove unused imports~
  • ~Remove remaining reliance on NESSAnticheat.getInstance()~
  • Deprecated and replace calls to ReflectionUtility with better practices including caching Field and Method instances.
  • Do much, much less inside the constructor of MovementValues
  • ~Avoid public fields in MovementValues~
  • Use proper visibility on all fields
  • ~Either remove or recode and un-deprecate NoSlowBow and NoSlowFood, which are noted as needing a complete recode.~
  • Add @override in a few places where it was for some reason omitted. Deprecated and replace calls to ReflectionUtility with better practices including caching Field and Method instances. = done