Add hyperlinkID to hero json file

heroespatchnotes / heroes-talents

Talent and ability descriptions for heroes in Heroes of the Storm in handy JSON format

https://heroespatchnotes.github.io/heroes-talents

MIT License

36 stars 19 forks source link

Add hyperlinkID to hero json file #107

Closed Zemill closed 4 years ago

Zemill commented 4 years ago

The new talent build copy process in patch 2.50 appears to use the hyperlinkID. Currently the json files are missing that value.

MGatner commented 4 years ago

We have hyperlinkID in its lower-case version as the "shortName". Since case is a one-way conversion I would be in favor of adding hyperlinkID and deprecating shortName so we could drop it a few patches down the road, since developers could always re-create it with lower($hyperlinkID). @stuaroo thoughts?

stuaroo commented 4 years ago

I like that idea, let's go that direction.