Closed lugehorsam closed 1 year ago
Just for the record, we had discussion about it and I was against this change for following reasons:
<setup C++ toolchain> && git clone && cmake --build
and dev need to follow setup instruction to make anything built
optional-lite
to build , it is also not included in produced artifact and as a result our binary builds are not self-sufficient anymore nakama-cpp-private
makes nakama-cpp
builds use different build (build flags, patches) of dependencies, meaning we introduce variability between platorms @redbaron What steps can be taken together to ensure that we can keep the two repositories broken apart as they need to be for legal reasons?
Let's figure out how to make it work and minimize the list of tradeoffs.
Allows another repository to depend on this via vcpkg and sets this up as a vcpkg registry so we can push the decision to whether we want to add this to the vcpkg built-in registry to another time.
Part of this was removing vcpkg as a subrepo, for a few reasons
Remove optional-lite from the CMake installation process. This was a wrong approach by me and is needed for vcpkg compatibility. Our any others trying to depend on ours via CMake should obtain optional-lite through their own means, e.g., a package manager like vcpkg.
[x] Update test and examples to pull in optional-lite
[ ] Document need to pull in optional-lite in README.md