search

heroiclabs / nakama-dart

Pure Dart Client for Nakama Server
https://heroiclabs.com/docs/nakama/client-libraries/dart
166 stars 51 forks source link

authenticateEmail doesn't match functionality in regards to username authentication #71

Closed goodiesohhi closed 1 year ago

goodiesohhi commented 1 year ago

Nakama actually supports the supplying of a username only instead of an email for authenticateEmail with attemptUsernameLogin = true but the flutter client does not have this functionality and there is no way to supply only a username and email is a required parameter.

mofirouz commented 1 year ago

Thanks for reporting this; Would you be interested in contributing the patch? This would actually be a good first issue to help contribute to the SDK.

goodiesohhi commented 1 year ago

I have made the changes. Lemme make a pull request.

goodiesohhi commented 1 year ago

Thanks for reporting this; Would you be interested in contributing the patch? This would actually be a good first issue to help contribute to the SDK.

Since this is my first pull request which branch do I make the pull request to? I assume develop?

NocoleNe commented 1 year ago

I also encountered this error. When can I get the new code?

obrunsmann commented 1 year ago

I also encountered this error. When can I get the new code?

Expect today :)