search

heroiclabs / nakama-dart

Pure Dart Client for Nakama Server
https://heroiclabs.com/docs/nakama/client-libraries/dart
166 stars 51 forks source link

Fix LeaderboardRecordList model mapper #79

Closed aminalaee closed 8 months ago

aminalaee commented 9 months ago

There's an issue in the LeaderboardRecordList.fromDto that doesn't map the records properly. This PR fixes the issue and adds some tests for it.

obrunsmann commented 9 months ago

Thank you @aminalaee - lgtm If I see this correctly, that should fix #52, right?

aminalaee commented 9 months ago

Yes, I think this is the fix.

aminalaee commented 8 months ago

@obrunsmann any chance for review and release of this?

obrunsmann commented 8 months ago

@obrunsmann any chance for review and release of this?

Yep today, latest tomorrow with the other PR 🎊