search

heroiclabs / nakama-defold

Defold client for Nakama server.
https://heroiclabs.com
Apache License 2.0
75 stars 12 forks source link

Update API #15

Closed AGulev closed 3 years ago

AGulev commented 3 years ago
novabyte commented 3 years ago

This looks really good @AGulev. Thanks for the contribution! 🙏

Can you add a CHANGELOG entry for the updates and would you like to start a contributor file or add yourself to the README as a contributor?

AGulev commented 3 years ago

Can you add a CHANGELOG entry for the updates and would you like to start a contributor file or add yourself to the README as a contributor?

I can do it ofc., but with Defold libraries/extentsions, we usually use releases page to track changes. Maybe it would be better to be consistent with the other Defold libs?

novabyte commented 3 years ago

Yep we also use releases as a typical distribution workflow in our other client SDKs:

https://github.com/heroiclabs/nakama-dotnet/releases

And we maintain a CHANGELOG for the SDK as well:

https://github.com/heroiclabs/nakama-dotnet/blob/master/CHANGELOG.md

I will standardize the workflow with this SDK to match the others we maintain moving forwards.

AGulev commented 3 years ago

Ok! Done! Thanks!

britzl commented 3 years ago

Yes, the changes look good! Thanks Alexey!

novabyte commented 3 years ago

Thanks again @AGulev 🙏