heroiclabs / nakama-defold

Defold client for Nakama server.
https://heroiclabs.com
Apache License 2.0
74 stars 12 forks source link

Include uri.lua license #34

Closed docsncode closed 2 years ago

docsncode commented 2 years ago

nakama/util/uri.lua includes a link to the original source blob, but doesn't mention or include the project's MIT license.

The license should be included, perhaps adding that module to it's own folder, renaming it to init.lua and including their LICENSE.md file.

cc @britzl

britzl commented 2 years ago

Very good point @seanpackham !

perhaps adding that module to it's own folder, renaming it to init.lua

Why a separate folder and why renaming the file?

Would it not be enough to add the copyright notice and license to the file itself? This is the license from the original repo:


The MIT License (MIT)

Copyright (c) 2015-2021 Daurnimator

Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

docsncode commented 2 years ago

@britzl just adding it to the license should be perfect!

britzl commented 2 years ago

@seanpackham PR with change: https://github.com/heroiclabs/nakama-defold/pull/35