search

heroiclabs / nakama-defold

Defold client for Nakama server.
https://heroiclabs.com
Apache License 2.0
74 stars 12 forks source link

Incorrect parameter name in `rpc_func` #71

Closed thomasbrq closed 5 months ago

thomasbrq commented 5 months ago

An error was returned because the parameter was payload instead of body.

CLAassistant commented 5 months ago

CLA assistant check
All committers have signed the CLA.

britzl commented 5 months ago

Thanks, but nakama.lua is generated from an API definition. See the codegen folder. The name payload originates from the API definition:

https://github.com/heroiclabs/nakama/blob/master/apigrpc/apigrpc.swagger.json#L2878-L2886

I see now though that there is both a key and an in field for each parameter and in the case of payload the in field has value body. This might be a new thing that the code generator doesn't take into account. I'll look into it!

britzl commented 5 months ago

Submitted new PR here: https://github.com/heroiclabs/nakama-defold/pull/73