search

heroiclabs / nakama-godot

Godot client for Nakama server written in GDScript.
Apache License 2.0
608 stars 72 forks source link

4.0 release changes #159

Closed theromis closed 1 year ago

theromis commented 1 year ago

cleaned for 4.0 release

dsnopek commented 1 year ago

Thanks!

This PR includes changes from #154, #155 and #157 -- all of which I've just merged. Looking at the remaining changes, it's not entirely clear what issue they are aiming to fix? Can you please clarify? Thanks again!

theromis commented 1 year ago

rest of it seems just addons/com.heroiclabs.nakama/utils/NakamaMultiplayerBridge.gd it adds OS.name() on session creation and checks if matchmaker_user.string_properties.get("os") is windows or macos to choose more powerful machines vs ios or android

dsnopek commented 1 year ago

Yeah, that code doesn't seem to relate to changes for Godot 4.0. And if that functionality is required, it should probably be done in a different way: allowing the game developer to provide their own rules for choosing the host, rather than hard-coding some checks on specific properties.

I'm going to close this PR for now, but I'd be happy to review a new PR or issue to figure out this new feature!