heroiclabs / nakama-godot

Godot client for Nakama server written in GDScript.
Apache License 2.0
607 stars 72 forks source link

Update Symbol Names to match Godot, Fix Request Call Args #186

Closed beelol closed 7 months ago

beelol commented 1 year ago

Change HTTPRequest -> HttpRequest to match Godot's new naming.

Change .Request call to contain 4 args to match new Godot signature for HttpRequest.Request

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

ericburns commented 7 months ago

@novabyte any update on pushing this change through? FWIW, I was stopping by to submit an identical PR. I'm working in Godot 4.2.1.stable.mono.official and this fixed it for me.

lugehorsam commented 7 months ago

Hey @ericburns and @beelol could either of you point us to where the naming has been changed? I still see it as HTTPRequest here -- https://docs.godotengine.org/en/stable/classes/class_httprequest.html

If it is now HttpRequest, was it type-aliased toHTTPRequest for backwards compatibility? In other words, how would this code still be working?

ericburns commented 7 months ago

@lugehorsam looks like there is an open PR about fixing the documentation https://github.com/godotengine/godot/pull/84421

*edit Some references about Godot 4's naming conventions: