Closed lugehorsam closed 1 year ago
@lugehorsam LGTM. I wasn't able to run the test suite due to errors. I know these were previously failing and we've discussed they need updating separately, I just wasn't sure if the changes you'd made were expected to fix these or not.
Hey @tomglenn yeah good question -- so they fixed some of the errors but I have found a couple others related to dependencies seeming to leak between workspaces. I was thinking I'd fix that in a separate PR if that makes sense to you.
@lugehorsam Yep cool that makes sense. 👍
ondisconnect
. Most browsers natively do pinging and ponging, but Chrome doesn't (see https://bugs.chromium.org/p/chromium/issues/detail?id=706002).send
andconnect
timeouts to the socket.README.md
commands for making builds.tsc
.It's not currently possible to write tests for this without some unsavory modifications to either the test runner or the client -- so I just tested using our
index.html
.