heroiclabs / nakama-js

JavaScript client for Nakama server written in TypeScript.
https://heroiclabs.com/docs/nakama/client-libraries/javascript/
Apache License 2.0
182 stars 54 forks source link

Add application-level ping pong #148

Closed lugehorsam closed 1 year ago

lugehorsam commented 1 year ago

It's not currently possible to write tests for this without some unsavory modifications to either the test runner or the client -- so I just tested using our index.html.

tomglenn commented 1 year ago

@lugehorsam LGTM. I wasn't able to run the test suite due to errors. I know these were previously failing and we've discussed they need updating separately, I just wasn't sure if the changes you'd made were expected to fix these or not.

lugehorsam commented 1 year ago

Hey @tomglenn yeah good question -- so they fixed some of the errors but I have found a couple others related to dependencies seeming to leak between workspaces. I was thinking I'd fix that in a separate PR if that makes sense to you.

tomglenn commented 1 year ago

@lugehorsam Yep cool that makes sense. 👍