search

heroiclabs / nakama-js

JavaScript client for Nakama server written in TypeScript.
https://heroiclabs.com/docs/nakama/client-libraries/javascript/
Apache License 2.0
195 stars 55 forks source link

authenticateFacebookInstantGame mixes up `username` and `create` #68

Closed leoncarl closed 4 years ago

leoncarl commented 4 years ago

https://github.com/heroiclabs/nakama-js/blob/master/src/client.ts#L794 username and create parameters are out of order. Any call with create: true will in fact create a user with username = "true". This means you can only create one user when using this authentication type as username needs to be uniq.

lugehorsam commented 4 years ago

Thanks for catching @leoncarl