heroiclabs / nakama-unity

Unity client for Nakama server.
https://heroiclabs.com/docs/unity-client-guide
Other
411 stars 75 forks source link

Add Unity socket that handles events on the main thread #102

Closed lugehorsam closed 3 years ago

lugehorsam commented 3 years ago

Closes #80

For the default parameter to CreateSocket, I defaulted useMainThread to false. The upside is that behavior wont unexpectedly change for existing users. But the downside is that users have to opt-in for the most straightforward adapter. Was thinking we have a quick chat about this.

Meneleus commented 3 years ago

This would be nice. I’ve had to add code to all my socket handlers to run on main thread.

novabyte commented 3 years ago

@lugehorsam Looks good to me let's merge it in! 👍

vivekmyyhash commented 1 year ago

Great fix, but can you also add this in the documentation too? It would be really helpful for new users.

image

novabyte commented 1 year ago

@vivekmyyhash That's a good suggestion. We'll update the docs /cc @heroiclabs/devrel