search

heroiclabs / nakama-unity

Unity client for Nakama server.
https://heroiclabs.com/docs/unity-client-guide
Other
411 stars 75 forks source link

Authentication timeout on WebGL is fixed at 15 seconds #103

Closed DaveOak closed 3 years ago

DaveOak commented 3 years ago

Changing the timeout in config.yml works for Android and iOS builds but makes no difference to WebGL builds that use UnityWebRequestAdapter. The timeout appears to be 15 seconds.

For context, a Facebook player with > 1000 playing friends causes a long delay (approx 17 seconds) on authentication while the friends list is imported.

lugehorsam commented 3 years ago

@DaveOak Thanks for filing this issue. This is now fixed in this patch: https://github.com/heroiclabs/nakama-unity/commit/4d4240c00ffd35733cb314c1ced6393a69208bdb

You can use it now using the instructions in the README or wait for a Unity Asset Store release if you're using our package that way, though the former approach is recommended.

DaveOak commented 3 years ago

Hi Luke

Thanks for the fix. Iā€™m unsure of how to install it though. I tried adding this line to my manifest.json but the build now hangs at the authenticate call.

"com.heroiclabs.nakama-unity": "https://github.com/heroiclabs/nakama-unity.git?path=/Packages/Nakama#4d4240c00ffd35733cb314c1ced6393a69208bdbā€

I previously downloaded and installed the 2.7.0 unity package.

Thanks.

On 30 Jan 2021, at 01:02, Luke notifications@github.com wrote:

@DaveOak https://github.com/DaveOak Thanks for filing this issue. This is now fixed in this patch: 4d4240c https://github.com/heroiclabs/nakama-unity/commit/4d4240c00ffd35733cb314c1ced6393a69208bdb You can use it now using the instructions in the README or wait for a Unity Asset Store release if you're using our package that way, though the former approach is recommended.

ā€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/heroiclabs/nakama-unity/issues/103#issuecomment-770126417, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7YAUYAXWJLX6RKKGHBRE3S4NLCBANCNFSM4WSBLFWQ.

lugehorsam commented 3 years ago

Hey @DaveOak, it looks like you imported it correctly. Is the hanging still only just for WebGL builds? Could you share the piece of code that hangs?

DaveOak commented 3 years ago

Hi Luke, thanks for confirming my approach was OK. The hanging problem turned out to be a bug in my own code. The timeout now works correctly when I set _client.Timeout in my code before authenticating.

lugehorsam commented 3 years ago

šŸŽ‰