search

heroiclabs / nakama-unity

Unity client for Nakama server.
https://heroiclabs.com/docs/unity-client-guide
Other
411 stars 75 forks source link

Fixing UnityWebRequest warning #116

Closed bkcetinkaya closed 3 years ago

bkcetinkaya commented 3 years ago

Linked an issue #115

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

sslila commented 3 years ago

Hi, Any ETA on this to be available? I am getting compiler error as we have configured our project to treat warning as error.

lugehorsam commented 3 years ago

Hey @kaancetinkayasf thanks for this. You may need to check my syntax on the global define here, but could you wrap your change in an #if UNITY_2020_2_OR_NEWER or equivalent so that we still support Unity 2018 LTS? And then keep the old code for the older versions of Unity.

bkcetinkaya commented 3 years ago

Hey, @lugehorsam thank you for your response. I have modified it as you said. It will not throw a warning on newer versions anymore. And still, support older versions of Unity.

lugehorsam commented 3 years ago

This has been resolved on master and will be incorporated into the next release: https://github.com/heroiclabs/nakama-unity/commit/402e31bb84bebcfa23644d39de95dce9af034300