heroiclabs / nakama-unity

Unity client for Nakama server.
https://heroiclabs.com/docs/unity-client-guide
Other
417 stars 75 forks source link

Support the unity package manager #92

Closed lugehorsam closed 4 years ago

lugehorsam commented 4 years ago

As rightfully requested by @thegoldenmule

This mostly involved shuffling files around into a particular folder structure and creating assembly definitions for the Editor and Runtime bundles of our scripts.

Here's what it looks like in the package manager:

Screen Shot 2020-07-28 at 9 20 48 PM

Closes #91

lugehorsam commented 4 years ago

I was looking for ways for the "In Development" label to not show up. As far as I can tell, unless the user downloads our package in UPM via the Asset Store, we will have that label. So that is a bit annoying but I am not sure if there's anything we can do about it. Obviously we'll still publish to the Asset Store so it'll go away if users use that flow rather than a git url.

novabyte commented 4 years ago

@lugehorsam Awesome. I have only a small follow up request. We should document the steps to add this client with UPM to the README and the client guide page on the docs.

thegoldenmule commented 4 years ago

@lugehorsam This is awesome!

lugehorsam commented 4 years ago

@novabyte There are a few different ways of doing it which is why I kept it vague. But perhaps I document the asset store and git url examples since I'd imagine those are the two most common ways of doing it.

lugehorsam commented 4 years ago

@novabyte Done. One of the new methods is to download a .tar from the releases page and import it into UPM. However, that will be an unsupported README.md instruction until we make a new release. Thoughts on making a new release?

Edit: Also, the other method (update manifest.json) is unsupported until we make a new release.

novabyte commented 4 years ago

@lugehorsam We should cut a new release but I want to bring in the changes to the .NET client that @thegoldenmule contributed that resolves an issue with encoding JSON numeric primitives.

lugehorsam commented 4 years ago

Added 9498008 because Unity complains if you import a package that doesn't have .meta files.

novabyte commented 4 years ago

@lugehorsam I think we can merge this into master. The latest .NET client release is out and we can prepare for a release of the Unity client.