search

heroiclabs / nakama

Distributed server for social and realtime games and apps.
https://heroiclabs.com
Apache License 2.0
8.58k stars 1.06k forks source link

HandleRPC does not panic anymore on an untagged gRPC call #1233

Closed intinig closed 1 week ago

intinig commented 2 weeks ago

The fix applied to v3.22.0 does not completely solve the problem of untagged gRPCs, with the panic now moved to a nil dereference to m.Metrics.CountUntaggedGrpcStatsCalls(1).

I applied a simple fix by wrapping it in a double check for non-nil, this makes it work again for us.

syhpoon commented 1 week ago

Thanks @intinig ! This PR (https://github.com/heroiclabs/nakama/pull/1234) should solve the root cause of this problem.

intinig commented 1 week ago

thx