heroku-python / conda-buildpack

[DEPRECATED] Buildpack for Conda.
MIT License
157 stars 251 forks source link

migrate to using miniconda #4

Closed applio closed 10 years ago

applio commented 10 years ago

Anaconda is great though I suggest that the closely related Miniconda is even more on target for Heroku deployments because it seeks to install only the packages required (whereas Anaconda has a larger core set of packages that come as part of any install, before further customization).

The proposed changes in this pull request provide:

I realize you likely haven't touched this project in some time. There are still other aspects of the scripts in this buildpack that deserve further investigation but I believe the changes I'm proposing already result in a generally useful/reusable package. Thank you for having taken the time to put together this buildpack in the first place -- without your efforts I would never have been inspired to make this work.

bnjmnt4n commented 10 years ago

:+1: @applio It looks like you’ve done some great work. Question: have you tested your changes and made sure it works? If so, I look forward to this being merged!

bnjmnt4n commented 10 years ago

I noticed that you commented out the mv line, I don’t think it would work without that.

applio commented 10 years ago

@d10 It's been working well for me with regular use on existing and on new sites on heroku over the last 2 months.

That mv is unnecessary when miniconda is explicitly told to install into /app in the first place in the line right before it:

./Miniconda-latest-Linux-x86_64.sh -b -p /app/.heroku/miniconda

Thanks for taking a careful look at it all.

bnjmnt4n commented 10 years ago

Ah, didn’t notice that. :+1: for merging this in. @applio do you mind if I use your fork for my project until it gets merged?

applio commented 10 years ago

@d10 Go for it -- no reason to wait on the merge.

kennethreitz commented 10 years ago

I never saw this! Looks like we implemented almost identical changes :)

kennethreitz commented 10 years ago

taking bits and pieces from this :)

bnjmnt4n commented 10 years ago

@kennethreitz awesome :)