heroku-python / dj-static

DEPRECATED - use WhiteNoise instead!
http://kennethreitz.org/introducing-dj-static/
BSD 2-Clause "Simplified" License
511 stars 74 forks source link

Make compatible with Django Dev (1.7+) #15

Closed gciding closed 10 years ago

gciding commented 10 years ago

get_path_info was moved from django.core.handlers.base to django.core.handlers.wsgi in commit 636860f. See https://github.com/django/django/commit/636860f

Here is a sample patch that illustrates the move, suggests a backwards compatible change. It may not be the cleanest way to do this, but it illustrates the change required.

rca commented 10 years ago

Awesome, this helped, thanks!

kennethreitz commented 10 years ago

:sparkles: :cake: :sparkles:

pydanny commented 10 years ago

Normally, I'm not keen on accepting stuff like this so early. It's a try/except statement on code that's at least 5 months away from being finalized. That's the optimistic deadline, and it will probably be more like 7-8 months. Fortunately, this is something that the framework is heading to.

kennethreitz commented 10 years ago

It's really not a big deal.