search

heroku / barnes

Tell StatsD about request time, GC, objects and more. Latest Rails 4 and Ruby 2.1 support, and ancient Rails 2 and Ruby 1.8 support.
MIT License
0 stars 0 forks source link

Compatibility with Puma master #32

Closed bdewater closed 4 years ago

bdewater commented 4 years ago

Puma master will return a hash instead of a JSON string which doesn't need to be parsed anymore: https://github.com/puma/puma/pull/2086

Closes https://github.com/heroku/barnes/issues/31

schneems commented 4 years ago

Thanks for the PR. I’m going to revert the puma behavior because it would break backwards compatibility with existing apps.

On Thu, May 7, 2020 at 9:09 PM Bart de Water notifications@github.com wrote:

Puma master will return a hash instead of a JSON string which doesn't need to be parsed anymore: puma/puma#2086 https://github.com/puma/puma/pull/2086

You can view, comment on, or merge this pull request online at:

https://github.com/heroku/barnes/pull/32 Commit Summary

  • Compatibility with Puma master

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/heroku/barnes/pull/32, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAOSYB7NS7GH3JJDU2INADRQNSUHANCNFSM4M32CM3Q .

-- Richard Schneeman https://www.schneems.com he/him