search

heroku / buildpacks-nodejs

Heroku's Cloud Native Buildpacks for Node.js applications.
BSD 3-Clause "New" or "Revised" License
2 stars 2 forks source link

Added missing changelog entries for npm buildpacks #697

Closed colincasey closed 1 year ago

colincasey commented 1 year ago

The composite buildpack heroku/nodejs should have had entries added for the new npm buildpacks merged in PRs:

joshwlewis commented 1 year ago

@colincasey I disabled auto-merge, since it looks like there should have been a merge conflict in the ## Removed section. Maybe try rebasing this?

colincasey commented 1 year ago

weird, the merge didn't complain about a conflict but duplicated the # Removed section twice

edmorley commented 1 year ago

CI has been running ~15 mins and some jobs haven't even started yet - due to waiting for instances of the pub-hk-ubuntu-22.04-large runner to be available. It might be the case that switching those jobs to the smaller default runner may end up being quicker (even with fewer CPUs/less memory), due to less wait time. (This could be offset by splitting the tests more and/or reducing the size of some of the test fixtures, so they install fewer packages etc).