Closed edmorley closed 11 months ago
The text of the current error message needs to be moved to an info level logger call, and then detect needs to return DetectResultBuilder::fail().build()
not an Err
.
The tests in this repo ideally would also be updated to catch this.
Python's implementation for reference: https://github.com/heroku/buildpacks-python/blob/eed94d4e6214232d7cef3b85785bc71a9609e7c9/src/main.rs#L45-L50 https://github.com/heroku/buildpacks-python/blob/eed94d4e6214232d7cef3b85785bc71a9609e7c9/tests/detect_test.rs#L7-L21
cc @colincasey @joshwlewis
The
heroku/nodejs-npm-install
buildpack is currently erroring if apackage.json
is not found, rather than gracefully "failing" detect.For example:
From: https://github.com/heroku/cnb-builder-images/actions/runs/6870978876/job/18686993769#step:6:10