heroku / buildpacks-nodejs

Heroku's Cloud Native Buildpacks for Node.js applications.
BSD 3-Clause "New" or "Revised" License
2 stars 2 forks source link

Refine the warning displayed when node_modules is detected in the application directory #736

Open colincasey opened 11 months ago

colincasey commented 11 months ago

When the nodejs-npm-install buildpack runs it's build process, it checks for the presence of a node_modules folder in the application directory and emits a warning if the folder is found.

This warning makes sense when the buildpack executes on Heroku since a build is triggered by a Git push and that would indicate the user has checked in node_modules into their source control. But, when running pack locally, this warning is not required. The check should be refined to: