search

heroku / buildpacks-nodejs

Heroku's Cloud Native Buildpacks for Node.js applications.
BSD 3-Clause "New" or "Revised" License
2 stars 2 forks source link

Add retries to Node.js binary download #868

Open edmorley opened 4 months ago

edmorley commented 4 months ago

To reduce the chance of intermittent failures like:

[Heroku Node.js Engine Buildpack]

[Checking Node.js version]
Detected Node.js version range: >=20.0.0 <21.0.0-0
Resolved Node.js version: 20.15.0

[Installing Node.js distribution]
Downloading Node.js 20.15.0 (linux-amd64) from https://nodejs.org/download/release/v20.15.0/node-v20.15.0-linux-x64.tar.gz

[Error: Node.js engine distribution error]
Couldn't download Node.js distribution: I/O error while downloading file: response body closed before all bytes were read

As seen in: https://github.com/heroku/cnb-builder-images/actions/runs/9699157499/job/26767524369?pr=541#step:6:27 https://github.com/heroku/cnb-builder-images/actions/runs/9699157499/job/26767523738?pr=541#step:6:28

usiegj00 commented 1 week ago

Seeing this too in a build that worked fine with the Heroku-themed buildpack. Can you articulate the difference in operation between the two buildpacks? This would help point to a potential fix here.