search

heroku / buildpacks-nodejs

Heroku's Cloud Native Buildpacks for Node.js applications.
BSD 3-Clause "New" or "Revised" License
24 stars 14 forks source link

Automatically detected processes with a Procfile #908

Open joshwlewis opened 4 weeks ago

joshwlewis commented 4 weeks ago

Consider an app with an index.js and a Procfile with contents like:

worker: node index.js

When running a build with heroku/builder:24, this results an image with two processes:

web: node index.js
worker: bash -c node index.js

This is probably unexpected for the user. There is an extra process, and the extra web process is unlikely to accept http connections anyway.

My feeling is that we should probably avoid adding processes if we know the the procfile buildpack was detected and is part of the build plan.

joshwlewis commented 4 weeks ago

Related issue: https://github.com/heroku/buildpacks-go/issues/85