heroku / buildpacks-php

Heroku's Cloud Native Buildpack for PHP applications.
BSD 3-Clause "New" or "Revised" License
7 stars 2 forks source link

Simplify Cargo metadata for `publish = false` crates #74

Closed edmorley closed 6 months ago

edmorley commented 6 months ago

As of Cargo 1.75 the version property in Cargo.toml is now optional, and if omitted is the same as having specified version = "0.0.0" and publish = false: https://github.com/rust-lang/cargo/blob/master/CHANGELOG.md#cargo-175-2023-12-28 https://doc.rust-lang.org/cargo/reference/manifest.html#the-version-field

Therefore for crates that we do not publish, we can now remove both the version and publish properties, avoiding the need for the fake 0.0.0 version that differs from the actual buildpack version in buildpack.toml.

GUS-W-14821120.

edmorley commented 6 months ago

Blocked on #75.