heroku / buildpacks-php

Heroku's Cloud Native Buildpack for PHP applications.
BSD 3-Clause "New" or "Revised" License
8 stars 2 forks source link

Use the Procfile CNB from the builder in tests #88

Closed edmorley closed 6 months ago

edmorley commented 6 months ago

The Procfile CNB has just moved Docker Hub repo: https://github.com/heroku/buildpacks-procfile/pull/219

Instead of updating the repo URL used in the tests, I've switched the tests to use the Procfile CNB from the builder image instead.

This is now safe to do, since there is now only ever one Procfile version in the builder after: https://github.com/heroku/buildpacks-jvm/pull/608 https://github.com/heroku/buildpacks-nodejs/pull/696

Using the Procfile version from the builder has a few advantages:

There is the chance of breakage, should the upstream Procfile CNB make a breaking change, however, that should be very rare and will only affect tests, and seeing that breakage here is actually kinda the point :-)

GUS-W-14356096.