heroku / buildpacks-ruby

Heroku's Cloud Native Buildpack for Ruby applications.
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Use `pack build --force-color` in CI instead of `script` TTY workaround #255

Closed edmorley closed 8 months ago

edmorley commented 8 months ago

As of Pack 0.33.0 (which this repo is using thanks to #462), there is a new --force-color argument that makes pack build output logs in colour even if a TTY wasn't detected (as is the case on GHA): https://github.com/buildpacks/pack/releases/tag/v0.33.0

This makes the script -e -c TTY workaround unnecessary. (It's also not needed for any direct Cargo usages, since they are covered by the existing CARGO_TERM_COLOR: always.)

I've also:

GUS-W-14968745.

edmorley commented 8 months ago

Before: https://github.com/heroku/buildpacks-ruby/actions/runs/7773089782/job/21196326133#step:12:30 https://github.com/heroku/buildpacks-ruby/actions/runs/7773089782/job/21196326188#step:8:17

After: https://github.com/heroku/buildpacks-ruby/actions/runs/7784979705/job/21226560938?pr=255#step:12:29 https://github.com/heroku/buildpacks-ruby/actions/runs/7784979705/job/21226562513?pr=255#step:7:14