search

heroku / buildpacks-ruby

Heroku's Cloud Native Buildpack for Ruby applications.
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Support heroku-24 #280

Closed runesoerensen closed 5 months ago

runesoerensen commented 5 months ago

This PR adds support for heroku-24 including downloading arch specific Ruby binaries depending on the current host architecture.

The cache isn't currently invalidated if the host architecture changes.

schneems commented 5 months ago

It made more sense to move over to a new branch than to try to replay main on top of this. I am doing the work over at https://github.com/heroku/buildpacks-ruby/pull/284. I want to be mindful to not delete this branch until heroku/ruby has heroku-24 support on main and a release as I know some might be using this branch from git.

edmorley commented 5 months ago

as I know some might be using this branch from git.

The buildpack can't be used directly from a branch since it would need compiling. The only other scenario is where someone might be using a shared crate, but this PR doesn't touch shared code.

schneems commented 5 months ago

I've merged #284. I've queued up a major release GHA (since there's something marked as CHANGED due to the lifecycle requirement changing).

edmorley commented 5 months ago

Resolved by #284.