search

heroku / buildpacks-ruby

Heroku's Cloud Native Buildpack for Ruby applications.
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Test file copying preserves mtime #335

Closed schneems closed 3 days ago

schneems commented 4 days ago

Adds a test to ensure that a file copied via the AppCache feature preserves the file's original mtime.

In #302 I determined that as long as the files copied into the cache dir preserve the original mtime then the FIFO cache cleaning logic that we rely on is valid. This test closes out this comment that asserted we need to verify whether or not the buildpack preserved mtime when copying files https://github.com/heroku/buildpacks-ruby/issues/302#issuecomment-2415128173.

close 302

Commits are in historical order. I'm interested in feedback regarding tests, possibly some edge cases I've overlooked regarding test cases. app_cache.rs is approx 213 lines without comments or tests.

schneems commented 3 days ago

Cleaned up and re-opened https://github.com/heroku/buildpacks-ruby/pull/336