heroku / cli

Heroku CLI
https://devcenter.heroku.com/articles/heroku-cli
ISC License
855 stars 224 forks source link

heroku-cli broken for Win64 on Intel Ice Lake #1354

Open obfuscurity opened 5 years ago

obfuscurity commented 5 years ago

There appears to a bug associated with libuv when running under Windows 10 on Intel Ice Lake processors. Although this is not a native heroku-cli bug, it appears to affect users on the most recent Intel processor family (e.g. Intel Core i-7 10xxx chips).

What is the current behavior?

Attempting to run any interactive commands (login, update, etc) returns the following error. It appears to be an acknowledged bug in libuv, but the maintainers there are dismissing it as a simple time sync problem (hint: it's not). Note that I'm not running this in the WSL, but rather in the git-shell for Windows (also attempted in Powershell, same error).

$ heroku login
Assertion failed: new_time >= loop->time, file c:\ws\deps\uv\src\win\core.c, line 309

What is the expected behavior?

I would expect a prompt for my credentials.

$ heroku --version
heroku/7.33.3 win32-x64 node-v11.14.0

Windows 10 Home Version 1903 OS build 18362.267

Yonom commented 5 years ago

I can reproduce this error with the following config:

Heroku 7.33.3 Node 10.16.3 LTS Intel i7-1065G7 Windows 10 Home 1903 Build 18362.356 XPS 13 2 in 1 7390

bferriman commented 5 years ago

I am having the same issue on my new Surface 3 laptop.

heroku/7.33.3 win32-x64 node-v11.14.0 Intel i7-1065G7 Windows 10 Home Version 1903 Build 18362.295

Edit: I should add that I get this error whether using Git Bash or plain old Command Prompt. Still having the issue, and not really sure where to go for help with this.

Tim-Shaffer commented 5 years ago

I am having the same issue on a new Dell laptop.

heroku/7.33.3 win32-x64 node-v11.14.0 Intel(R) Core(TM) i7-1065G7 Windows 10 Pro Version 1903 OS build 18362.356

adrianlee commented 5 years ago

Same issue with my Surface 3 laptop with command prompt.

Intel i7-1065G7 Node 10.17.0 LTS Windows 10 Home Version 1903 Build 18362.295

reileybergin commented 5 years ago

Same issue as described above.

Surface 3 laptop Intel i7 -1065G7 Windows 10 Home Version 1903

Treygec commented 5 years ago

Same issue as above

Dell XPS 13 2 in 1 7390 Intel i7 - 1065G7 Windows 10 Pro Version 1903

suavelizard commented 5 years ago

Same issue as above

Dell XPS 13 2 in 1 7390 Intel i7 - 1065G7 Windows 10 Pro Version 1903

reileybergin commented 4 years ago

Has anyone made any headway recently on what could be the potential cause of this error? Not sure if this is something that Heroku can address or something much further upstream.

kateerogers commented 4 years ago

I am also experiencing this issue with the Surface 3 Laptop. How can we get this resolved?

ollytheninja commented 4 years ago

Same issue here: Microsoft Surface Pro 7 i5-1035G4 Windows 10 Pro 10.0.18362 Build 18362 I've tried using bcdedit /set useplatformclock false to switch clocks, no effect. Have also tried various mechanisms to sync / update clock.

suavelizard commented 4 years ago

Dell released a firmware update for the XPS that I believe updates the timing for Icelake. For other XPS users I suggest checking that you are running the latest BIOS.

ollytheninja commented 4 years ago

Oh wow, does that mean this is a hardware / firmware issue rather than an upstream library issue?

ollytheninja commented 4 years ago

Confirming firmware update SurfacePro7_Win10_17763_19.104.44031.0 fixed this on my Surface Pro 7 https://www.microsoft.com/en-us/download/details.aspx?id=100419

reileybergin commented 4 years ago

Can anyone confirm if a similar firmware update has been released for the Surface 3 Laptop?

reileybergin commented 4 years ago

Can anyone confirm if a similar firmware update has been released for the Surface 3 Laptop?

UPDATE: This bug is no longer an issue with the Surface 3 Laptop

janickil commented 4 years ago

Hi @reileybergin, what did you do to get rid of this problem? I have Surfave 3 Laptop with the most recent updates and I still run into this problem...

reileybergin commented 4 years ago

Hi @janickil. I wish I could be more helpful but one day I checked and it was just working. I did use intel's driver update https://downloadcenter.intel.com/ about a week before so maybe this did something but I'm not sure.

adrianlee commented 4 years ago

Downloading the latest firmware for the Surface Laptop 3 fixed it for me.

You'll need to follow the instructions here and download the appropriate update.

https://support.microsoft.com/en-us/help/4023482

On Wed, Jan 15, 2020, 11:57 AM Reiley Bergin notifications@github.com wrote:

Hi @janickil https://github.com/janickil. I wish I could be more helpful but one day I checked and it was just working. I did use intel's driver update https://downloadcenter.intel.com/ about a week before so maybe this did something but I'm not sure.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/heroku/cli/issues/1354?email_source=notifications&email_token=AAGBWV324ASEQU3TGG2YGRLQ55SLHA5CNFSM4I7VDY42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJBS6CI#issuecomment-574828297, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGBWV2VSBB7MWIKKTQ3MFDQ55SLHANCNFSM4I7VDY4Q .

rejhgadellaa commented 4 years ago

@adrianlee I tried installing the latest firmware for my Surface Laptop 3 Intel i7 but the issue persists.

Could you tell us which firmware you're on? If I check the Surface app it says UEFI 28.25.140.0.

This issue is driving me nuts :(

bferriman commented 4 years ago

@rejhgadellaa I'm on a Surface Laptop 3 i7 UEFI 28.25.140.0 and the issue cleared up for me sometime in Dec-Jan when others started having success. I didn't manually install a firmware update or anything. Good luck!

ripu2 commented 4 years ago

i5-1035G4 node - 12.0.18 model - HP spectre, getting the same error

ollytheninja commented 4 years ago

Hi @ripu2, have you tried latest driver update from HP or Intel?

ripu2 commented 4 years ago

Hi @ollytheninja , Didn't try the update but got the issue resolved by just synchronizing the clock

otisjnz commented 4 years ago

Just got the latest driver update from intel, nothing. Re synced clock after, nothing. I've run out of idea for this. Does anyone have any idea what could be causing it?

otisjnz commented 4 years ago

My system:

Windows 10 Home Version 1903 OS build 18362.267

ripu2 commented 4 years ago

@Tabogachi , try synchronizing your system clock, it'll resolve the issue.

otisjnz commented 4 years ago

Still no fix. I did npm audit, and it came up with:

  High            Prototype Pollution in node-forge

  Package         node-forge

  Patched in      >= 0.10.0

  Dependency of   firebase-tools

  Path            firebase-tools > @google-cloud/pubsub > google-auth-library
                  > gtoken > google-p12-pem > node-forge

  More info       https://npmjs.com/advisories/1561

  High            Prototype Pollution in node-forge

  Package         node-forge

  Patched in      >= 0.10.0

  Dependency of   firebase-tools

  Path            firebase-tools > @google-cloud/pubsub > google-gax >
                  google-auth-library > gtoken > google-p12-pem > node-forge

  More info       https://npmjs.com/advisories/1561

  High            Prototype Pollution in node-forge

  Package         node-forge

  Patched in      >= 0.10.0

  Dependency of   firebase-tools

  Path            firebase-tools > google-auth-library > gtoken >
                  google-p12-pem > node-forge

  More info       https://npmjs.com/advisories/1561

  High            Prototype Pollution in node-forge

  Package         node-forge

  Patched in      >= 0.10.0

  Dependency of   firebase-tools

  Path            firebase-tools > google-gax > google-auth-library > gtoken >
                  google-p12-pem > node-forge
otisjnz commented 4 years ago

Tried npm audit fix but it said it needed manual review

AlokJoshi commented 2 years ago

Just got the latest driver update from intel, nothing. Re synced clock after, nothing. I've run out of idea for this. Does anyone have any idea what could be causing it?

@Tabogachi did you find any solution. I am having the same error in server.js when using axios or superagent to fetch data from a third part site.

ollytheninja commented 2 years ago

Hey @AlokJoshi. what device have you got and have you installed the latest drivers and synchronized your clock?

otisjnz commented 1 year ago

Just got the latest driver update from intel, nothing. Re synced clock after, nothing. I've run out of idea for this. Does anyone have any idea what could be causing it?

@Tabogachi did you find any solution. I am having the same error in server.js when using axios or superagent to fetch data from a third part site.

I know this was almost a year ago, but to anyone searching this up, my computer randomly fixed it one day. Try reinstalling the software, and just installing things as that seemed to be the solution for me. Good luck