heroku / cli

Heroku CLI
https://devcenter.heroku.com/articles/heroku-cli
ISC License
851 stars 216 forks source link

Allow creating review apps #2117

Open AlecRust opened 1 year ago

AlecRust commented 1 year ago

Do you want to request a feature or report a bug?

Feature

What is the current behavior?

Background: We want to be able to trigger new review apps from the CLI, as the Heroku UI constantly logs you out.

The only way I can "click" the Heroku UI's "Create review app" button from the command line is via the Review App Create API.

This requires a public URL to a tarball of the repository that is passed to the API. For private GitHub repositories creating such a URL can be complicated (especially since GitHub deprecated URL param auth) and involves creating a tarball manually or authenticating and downloading it from GitHub, then uploading it somewhere like an S3 bucket or your sources endpoint.

You even have a help article dedicated to the complexity of this, but passing the token in the URL as suggested doesn't work for me 🤷

Here's an example of the kind of script required to achieve this. All this seems massively over complicated to simply trigger a new review app build.

What is the expected behavior?

I would have expected the Heroku CLI to provide a simple interface to trigger this "create review app" build on a specific PR, like you can in the pipeline UI. Something like:

heroku reviewapps create pr-1234
cercxtrova commented 5 months ago

Anything new around here? 👀

adacosta commented 5 months ago

+1 for CLI review app creation. 3300 branches makes the heroku UI dropdown take forever to populate and scroll. I've never removed a branch in my life. Screenshot 2024-02-06 at 3 28 02 PM

sbosio commented 3 months ago

Hi @AlecRust, @cercxtrova and @adacosta. I'm handling this to our product manager because it's a feature request, for appropriate tracking and prioritization.

ryandagg commented 1 month ago

I have a questionable workaround in the meantime. A browser's find functionality (cmd + f) works for that drop-down.