Heroku Local does not terminate correctly under WIndows

armordog commented 10 months ago

This project is for the Heroku CLI only and issues are reviewed as we are able. If you need more immediate assistence or help with anything not specific to the CLI itself, please use https://help.heroku.com.

Do you want to request a feature or report a bug?

BUG

What is the current behavior?

Terminating the local server with Ctrl+C always orphans the node process. So that running heroku local again complains that the port is in use. I have to manually kill the node process.

It says

[WARN] Interrupted by User
[DONE] Killing all processes with signal  SIGINT
^CTerminate batch job (Y/N)?

What is the expected behavior?

Ctrl+C should not orphan its processes.

Heroku Version: heroku/8.7.1 win32-x64 OS: Windows 10 Pro

k80bowman commented 10 months ago

@armordog thank you for reporting this, we will take a look.

justinwilaby commented 7 months ago

Hi @armordog -

We've looked at your issue with multiple attempts to reproduce the problem but have not had success. All child processes have terminated as expected in every scenario we tried.

When you get a chance, please clone the node-js-getting-started repo and run heroku local for the project and let me know if you can repro here. This is a simple program and will eliminate variables that may exist in more complex projects.

Also, please let us know your Node version and which terminal you are using, e.g. powershell, git BASH, cmd, zsh, etc. as this will help us zero in on specific behaviors. The message: Terminate batch job (Y/N)? indicates you may be using cmd.exe. Although I do not anticipate a different behavior when using a Powershell or Git BASH terminal, it may be worth trying in case system configurations are different.

Thank you!

sbosio commented 6 months ago

GUS Work Item (Heroku internal)

heroku / cli