search

heroku / cli

Heroku CLI
https://devcenter.heroku.com/articles/heroku-cli
ISC License
848 stars 220 forks source link

Windows - Add `DisplayVersion` key to registry #2905

Open onwardmk opened 2 months ago

onwardmk commented 2 months ago

This project is for the Heroku CLI only and issues are reviewed as we are able. If you need more immediate assistance or help with anything not specific to the CLI itself, please use https://help.heroku.com.

Do you want to request a feature or report a bug?

Bug

What is the current behavior?

I'm on Windows, and I use WinGet to manage packages on my system. When I upgrade my packages with WinGet, I have to use the --include-unknown flag to upgrade this package because the DisplayVersion key hasn't been added to the registry per this comment. In addition, I have to upgrade this package every time instead of only when a new version's been published because the WinGet doesn't know the current version that's installed.

Without --include-unknown:

image

With `--include-unknown:

image

What is the expected behavior?

WinGet should only upgrade this package when the version's been bumped without using the --include-unknown option.

zwhitfield3 commented 2 months ago

Hi @onwardmk, we're sorry you're experiencing this issue. Unfortunately, there is nothing we can do here as we don't own or manage the winget-cli. I would recommend opening an issue with winget-cli about this problem.

onwardmk commented 2 months ago

Hi @onwardmk, we're sorry you're experiencing this issue. Unfortunately, there is nothing we can do here as we don't own or manage the winget-cli. I would recommend opening an issue with winget-cli about this problem.

WinGet looks at a Windows registry setting on your application to know which version it's on; this setting is not unique to WinGet, it's on most Windows apps. I'm requesting that you add it to your application before publishing releases.

onwardmk commented 2 months ago

@zwhitfield3 can you re-open this?

sbosio commented 1 month ago

Hi @onwardmk,

Winget isn't currently a supported release channel for Heroku CLI. Windows installations should follow the instructions found in our Dev Center article.

The manifest files located at the Winget package manager repository have been created and contributed by external contributors unrelated with the Heroku CLI team and seem to be currently unmaintained.

I'm adding an internal ticket for our product owners to evaluate adding Winget to our automated release process.

sbosio commented 1 month ago

GUS Work Item for tracking purposes (Heroku internal).

onwardmk commented 1 month ago

@sbosio, great, thank you for the update.