search

heroku / cnb-shim

This is a shim to run old buildpacks as Cloud Native Buildpacks
MIT License
1 stars 0 forks source link

use http vs curl #25

Closed jsncmgs1 closed 3 years ago

jsncmgs1 commented 3 years ago

Removes curl and use http.Get.

There's probably a world where we drop shelling to tar and using go's lib, but that can come later.

jsncmgs1 commented 3 years ago

This looks nice. Couple of nits. Did you compare a buildpack produced by this to see if the contents of a buildpack produced are the same as prod today? I want to be sure we are producing the expected result.

I did compare, they're the same.