search

heroku / django-heroku

[DEPRECATED] Do not use! See https://github.com/heroku/django-heroku/issues/56
BSD 3-Clause "New" or "Revised" License
459 stars 142 forks source link

Updated dependency psycopg2 to psycopg2-binary #18

Closed karbassi closed 6 years ago

karbassi commented 6 years ago

Updated dependency psycopg2 to psycopg2-binary.

This can be merged or not since psycopg2 and psycopg2-binary are still being discussed around the net. Some like the change, some don't.

From psycopg's install docs, they say:

Note: The -binary package is meant for beginners to start playing with Python and PostgreSQL without the need to meet the build requirements. If you are the maintainer of a publish package depending on psycopg2 you shouldn’t use psycopg2-binary as a module dependency. For production use you are advised to use the source distribution.

Fixes #7

@kennethreitz What are your thoughts?

sigmavirus24 commented 6 years ago

It's not clear that psycopg2-binary is preferable for Heroku over psycopg2. Further, there are a lot of extra changes in this PR that are unrelated. Can you share your reasoning for wanting to use psycopg2-binary over psycopg2?

Based on the install documentation you quoted, given this is a library designed for production environments and is a library distributed via PyPI, it sounds like the psycopg2 project maintainer perspective is that we should not use the -binary package.