Do not replace `config['DATABASES']['default']`, do deep update or simple update or `dict(config['DATABASES']['default'], **dj_database_url.config(conn_max_age=MAX_CONN_AGE, ssl_require=True))` instead

heroku / django-heroku

[DEPRECATED] Do not use! See https://github.com/heroku/django-heroku/issues/56

BSD 3-Clause "New" or "Revised" License

459 stars 142 forks source link

Do not replace `config['DATABASES']['default']`, do deep update or simple update or `dict(config['DATABASES']['default'], **dj_database_url.config(conn_max_age=MAX_CONN_AGE, ssl_require=True))` instead #41

Open dmugtasimov opened 5 years ago

dmugtasimov commented 5 years ago

Do not replace config['DATABASES']['default'], do deep update or simple update or dict(config['DATABASES']['default'], **dj_database_url.config(conn_max_age=MAX_CONN_AGE, ssl_require=True)) instead.

The way it is implemented now sweeps out my ATOMIC_REQUESTS and other settings. Fixing this would also solve: https://github.com/heroku/django-heroku/issues/11