search

heroku / django-heroku

[DEPRECATED] Do not use! See https://github.com/heroku/django-heroku/issues/56
BSD 3-Clause "New" or "Revised" License
459 stars 142 forks source link

change to binary distro of psycopg2 #49

Closed sethb0 closed 4 years ago

sethb0 commented 4 years ago

The latest psycopg2 package always builds from source, which is counterproductive on Heroku. psycopg2-binary contains prebuilt drivers for supported architectures and should be used instead.

logandonley commented 4 years ago

This should resolve #48 and #46. Plus psycopg2 tells you to use psycopg2-binary.

sigmavirus24 commented 4 years ago

Given that builds and wheels are cached on Heroku, there's little counterproductive here. The wheels for psycopg2-binary include openssl which means any updates made to the stack images openssl libraries would bypass your application's security. The fact that psycogp2 warns to use -binary in all situations is unfortunate.

In the future please read previously opened (and closed) issues prior to opening new ones.

sethb0 commented 4 years ago

The fact that build issues with psycopg2 on the development host make it impossible to deploy an app is also "unfortunate." Would you suggest taking the wrapped openssl issue up with that team?

Fingel commented 4 years ago

I agree that this is pretty obnoxious. This means the default howto instructions for Django on Heroku result in headaches on some platforms and warnings on all of them.