search

heroku / docker-registry-client

A Go API client for the v2 Docker Registry API
BSD 3-Clause "New" or "Revised" License
297 stars 225 forks source link

Can you guys remove the vendor dir from the repo? #17

Closed treeder closed 7 years ago

treeder commented 8 years ago

Causes issues like:

drivers/docker/docker.go:126: cannot use mani (type *"github.com/iron-io/runner/vendor/github.com/heroku/docker-registry-client/vendor/github.com/docker/distribution/manifest/schema1".SignedManifest) as type *"github.com/iron-io/runner/vendor/github.com/docker/distribution/manifest/schema1".SignedManifest in field value
drivers/docker/docker.go:144: cannot use r.Digest (type "github.com/iron-io/runner/vendor/github.com/docker/distribution/digest".Digest) as type "github.com/iron-io/runner/vendor/github.com/heroku/docker-registry-client/vendor/github.com/docker/distribution/digest".Digest in argument to s.reg.LayerMetadata
dmathieu commented 8 years ago

What dependency manager are you using? Most tools (godep, glide, govendor etc) will flatten vendor folders when fetching dependencies.

freeformz commented 8 years ago

Use glide i -v (or glide get -v <pkg>) to strip deps vendor dirs. I don't know why glide makes this hard.

treeder commented 8 years ago

Thx guys, trying the -v flag.

jkarneges commented 7 years ago

I'm hitting this issue when running make build (after having run make dep, which runs glide install --strip-vendor). I also tried manually running glide i -v but no change. Any ideas?

Edit: wrong project. Meant to file this against ironfunctions.