search

heroku / heroku-apps

Heroku Core CLI Plugin for managing Heroku apps
https://cli.heroku.com
ISC License
19 stars 26 forks source link

shield: stop converting Private-* dynos to Shield-* dynos #193

Open jdx opened 7 years ago

jdx commented 7 years ago

This stops the cosmetic change of Private- dynos to Shield- dynos for Shield Private Spaces. When Api begins sending the actual Shield dyno types then this cosmetic switcheroo will no longer be necessary.

codecov[bot] commented 7 years ago

Codecov Report

Merging #193 into master will increase coverage by 0.27%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
+ Coverage   19.32%   19.59%   +0.27%     
==========================================
  Files          72       72              
  Lines        1449     1429      -20     
  Branches      276      267       -9     
==========================================
  Hits          280      280              
+ Misses        913      902      -11     
+ Partials      256      247       -9
Impacted Files Coverage Δ
src/commands/ps/scale.js 20% <ø> (+6.11%) :arrow_up:
src/commands/ps/index.js 6.49% <ø> (+0.32%) :arrow_up:
src/commands/ps/type.js 17.14% <ø> (+2.14%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e57b303...41b81f3. Read the comment docs.