search

heroku / heroku-apps

Heroku Core CLI Plugin for managing Heroku apps
https://cli.heroku.com
ISC License
19 stars 26 forks source link

Make release pending wording consistent #197

Closed dmathieu closed 7 years ago

dmathieu commented 7 years ago

This was introduced to be consistent with releases not running concurrently. That project never came to be though.

Closes #192

dmathieu commented 7 years ago

The failing test seems to be entirely unrelated to this change, and due to project-wide styling issues.

codecov[bot] commented 7 years ago

Codecov Report

Merging #197 into master will decrease coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
- Coverage   95.77%   95.75%   -0.03%     
==========================================
  Files          76       76              
  Lines        1514     1506       -8     
  Branches      289      285       -4     
==========================================
- Hits         1450     1442       -8     
  Misses         62       62              
  Partials        2        2
Impacted Files Coverage Δ
src/status_helper.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 633f137...7dc0810. Read the comment docs.

jdx commented 7 years ago

not sure why the build started failing (the last runs all were green), but I fixed it and pushed up the fix to this branch for you

dmathieu commented 7 years ago

I saw a lot of warnings and thought it was the failure reason, missing the one error due to my change 😄