Open jdowning opened 7 years ago
looks great! but we should really have a test for at least the happy path of ps:wait
. I can give you a hand writing that if you like.
Merging #208 into master will decrease coverage by
2.05%
. The diff coverage is20.93%
.
@@ Coverage Diff @@
## master #208 +/- ##
==========================================
- Coverage 95.72% 93.67% -2.06%
==========================================
Files 76 78 +2
Lines 1521 1564 +43
Branches 289 301 +12
==========================================
+ Hits 1456 1465 +9
- Misses 62 85 +23
- Partials 3 14 +11
Impacted Files | Coverage Δ | |
---|---|---|
src/ps_wait.js | 6.06% <6.06%> (ø) |
|
src/commands/ps/restart.js | 93.75% <66.66%> (-6.25%) |
:arrow_down: |
src/commands/ps/wait.js | 71.42% <71.42%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ae5df4f...513c873. Read the comment docs.
This adds a function
ps_wait
that is mostly pulled from uhoh-itsmaciek/heroku-ps-wait. This allows a user to runheroku ps:wait
to wait for all dynos to be up and running. Additionally, this adds a flag tops:restart
(--wait
) to run theps_wait
function after initializing the restart.