search

heroku / heroku-apps

Heroku Core CLI Plugin for managing Heroku apps
https://cli.heroku.com
ISC License
19 stars 26 forks source link

add strict-tls disable warning & confirmation #212

Closed RasPhilCo closed 6 years ago

RasPhilCo commented 6 years ago

Fixes https://github.com/heroku/cli/issues/598

RasPhilCo commented 6 years ago

@jdxcode @brettgoulder @andre5oto

Do we still need to warn if the confirm flag is used? See test https://github.com/heroku/heroku-apps/pull/212/files#diff-5aaddd5441d59922c8aaf06d43241c2aR76

codecov[bot] commented 6 years ago

Codecov Report

Merging #212 into master will increase coverage by 0.04%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #212      +/-   ##
==========================================
+ Coverage   95.72%   95.77%   +0.04%     
==========================================
  Files          76       76              
  Lines        1522     1538      +16     
  Branches      289      292       +3     
==========================================
+ Hits         1457     1473      +16     
  Misses         62       62              
  Partials        3        3
Impacted Files Coverage Δ
src/commands/labs/disable.js 100% <100%> (ø) :arrow_up:
test/jest.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 40b413c...fda104d. Read the comment docs.

andre5oto commented 6 years ago

@RasPhilCo no need to add message when enabling confirm flag. This looks good. Tnx.